Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [typescript-angular] unable to run npm install after generating client #11970

Open
libliflin opened this issue Mar 25, 2022 · 9 comments
Open

Comments

@libliflin
Copy link

Hi,

Please confirm tsickle version aligns with typescript version in most updated maven central jar. Currently they do not align (~4.3 and >=4.4.0 respectively) and npm install requires --force.

Suggested fix: remove tsickle from requirements for generated typescript code.

@iErKy
Copy link

iErKy commented May 27, 2022

Hello,
I've got same problem here, tsickle has compatibility problems with most recent typescript version (>=4.4.0), answer for this issues on angular/tsickle is avoid using it unless you really need it.

#angular/tsickle#1322

Suggested fix: remove tsickle

@ddurham2
Copy link
Contributor

I had to remove tsickle from the generated package's devDependencies as well. The latest tsickle (0.46) release doesn't even install.

@wing328
Copy link
Member

wing328 commented Jun 16, 2022

@ddurham2 thanks for sharing a fix. Can you please file a PR with the suggested fix when you've time?

@ddurham2
Copy link
Contributor

ddurham2 commented Jun 16, 2022

same as #11233 and #12483

@ddurham2
Copy link
Contributor

ddurham2 commented Jun 16, 2022

oh, I just run
sed -e 's/.*tsickle.*//' -i package.json
as part of my pipeline before installing/building/publishing,,,

And so, as far as I know, the fix is to just remove tsickle from package.json here

I'm not entirely sure what tsickle is useful for. Their page itself says it's experimental.

Being in the devDependences, it's not entirely necessary for deployed apps.

@kyryl-bogach
Copy link

The issue is still present

@blaghed
Copy link

blaghed commented Dec 1, 2022

Can confirm this is still happening on v6.2.1 (current master).
I'm able to fix this by having my own template "package.mustache" without the "tsickle" dependency, but would love for a fix at source.
Do you need someone to contribute this 1 line removal?

@M-a-c-Carter
Copy link

@blaghed I was building fine without it.
also its not really something that should be used apparently
angular/tsickle#1429

@M-a-c-Carter
Copy link

and for that matter @ddurham2 's solution is valid, but there should be an update to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants