Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java Modules #113

Open
aalmiray opened this issue Feb 28, 2023 · 1 comment
Open

Support Java Modules #113

aalmiray opened this issue Feb 28, 2023 · 1 comment

Comments

@aalmiray
Copy link

aalmiray commented Feb 28, 2023

v3.8.0 defines an automatic module name

$ jarviz module name --file feign-form-3.8.0.jar 
subject: feign-form-3.8.0.jar
name: feign.form
source: filename
automatic: true
valid: true

$ jarviz module descriptor --file feign-form-3.8.0.jar 
subject: feign-form-3.8.0.jar
name: feign.form
version: 3.8.0
open: false
automatic: true
requires:
  java.base mandated
contains:
  feign.form
  feign.form.multipart
  feign.form.util

I'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume feign-form, specifically those that create custom Java Runtimes with jlink, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.

FWIW feign 12.2 added full module descriptors to a set of its Maven modules -> OpenFeign/feign#1357

@aalmiray
Copy link
Author

Would love to have a new release with explicit Java module support, now that core Feign also provides explicit module descriptors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant