Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java11 client should consider Options::connectTimeoutMillis #1306

Closed
gb-klein opened this issue Nov 9, 2020 · 1 comment · Fixed by #1307
Closed

java11 client should consider Options::connectTimeoutMillis #1306

gb-klein opened this issue Nov 9, 2020 · 1 comment · Fixed by #1307
Labels
bug Unexpected or incorrect behavior

Comments

@gb-klein
Copy link
Contributor

gb-klein commented Nov 9, 2020

feign.http2client.Http2Client seems not to consider Options::connectTimeoutMillis. In the course of #1233 request timeout was fixed - but not the connect timeout.

Implementation note: this would have to be set on the HttpClient instance (e.g. via Builder::connectTimeout). One could do this manually by providing a custom built HttpClient to Http2Client. However it would be good to leave this over to Http2Client when it constructs the HttpClient for us. E.g. by replacing the default constructor with a constructor taking Options or (IMHO better) lazily instantiating HttpClient - if no custom was specified via constructor - when the request should be sent.

@ChunMengLu
Copy link
Contributor

Yes, it is more complicated to implement.

I think it is enough to customize connectTimeoutMillis in most scenarios on HttpClient.

@kdavisk6 kdavisk6 added the bug Unexpected or incorrect behavior label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants