Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overview.png has black text on (possibly) black background #1358

Closed
C-Otto opened this issue Jan 24, 2021 · 4 comments
Closed

overview.png has black text on (possibly) black background #1358

C-Otto opened this issue Jan 24, 2021 · 4 comments
Labels
documentation Issues that require updates to our documentation

Comments

@C-Otto
Copy link

C-Otto commented Jan 24, 2021

With GitHub dark mode the text in https://github.com/OpenFeign/feign/blob/master/src/docs/overview.png cannot be seen, as it is black on black. Please make sure the text is readable with both black and white backgrounds.

@kdavisk6 kdavisk6 added the documentation Issues that require updates to our documentation label Mar 12, 2021
@kdavisk6
Copy link
Member

At the moment, there is nothing we can do about this. Github is tracking an issue related to this however.

@ashleyfrieze
Copy link
Contributor

@kdavisk6 the mindmap is a PNG file. Can it be generated with a background, rather than transparent?

@ashleyfrieze
Copy link
Contributor

Alternatively, if the mindmap were rendered as PlantUML - stored as PlantUML markdown in the repo, and then embedded into the README like this - https://raw.githubusercontent.com/jonashackt/plantuml-markdown/master/README.md - it might be a longer-term option and easier to maintain?

@kdavisk6
Copy link
Member

Closed with #1396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that require updates to our documentation
Projects
None yet
Development

No branches or pull requests

3 participants