Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeignMetricTagResolver lost Exception tag #1716

Closed
pangengteng opened this issue Aug 8, 2022 · 1 comment · Fixed by #1720
Closed

FeignMetricTagResolver lost Exception tag #1716

pangengteng opened this issue Aug 8, 2022 · 1 comment · Fixed by #1720

Comments

@pangengteng
Copy link

when call the method "feign.micrometer.FeignMetricTagResolver#tag(feign.MethodMetadata, feign.Target<?>, java.lang.Throwable, io.micrometer.core.instrument.Tag...)" as below, the "e" was lost as not pass to the inner method

public Tags tag(MethodMetadata methodMetadata, Target<?> target, Throwable e, Tag... tags) {
return tag(methodMetadata.targetType(), methodMetadata.method(), target.url(), tags);
}

@eshishkin
Copy link
Contributor

Hi, I met the same issue in our project a couple of days ago. I created a PR (#1720), so it should solve the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants