Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder breaks resilience4j 1.7.x (latest java <17 compatible release) #2341

Closed
nilo85 opened this issue Mar 5, 2024 · 3 comments
Closed

Comments

@nilo85
Copy link

nilo85 commented Mar 5, 2024

As introduced in #2117

It seems feign breaks the builder pattern by breaking the builder chain and returning a new builder. this effectivly disables any extension builders as such defined by resilience4j.

https://github.com/resilience4j/resilience4j/blob/master/resilience4j-feign/src/main/java/io/github/resilience4j/feign/Resilience4jFeign.java#L60

@nilo85
Copy link
Author

nilo85 commented Mar 5, 2024

Looking at current master version of resilience4j I suspect its the case with 2.X too

@nilo85
Copy link
Author

nilo85 commented Mar 5, 2024

After some back and forth I think this is an issue with resilience4j.
I made a PR that addresses this here in resilience4j resilience4j/resilience4j#2127

@nilo85
Copy link
Author

nilo85 commented Mar 5, 2024

Closing as I do not think issue will be resolved from this end of the problem =)

@nilo85 nilo85 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant