The version of the function is wrong when publishing with the specified function tag.

[Bryce-huang]

Description
A clear and concise description of what the bug is.
Specify the image tag when publishing the function. The actual function version will always be the previous version built based on the source code.
Environmental
Tell us what your cluster environment is like, e.g.

• Operating System Information linux
• kubernetes version v1.24
• OpenFunction version v1.10
• knative 1.10

Expected behavior
Tell us what should happen.
The right version wil run in serving.

Actual behavior

The actual function version will always be the previous version built based on the source code.

To Reproduce
Steps to reproduce the behavior:

1. Build function version 1 from source code
2. Access function,It return version 1
3. Specify image tag to function with version 2
4. Access function,it will return version 1

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[benjaminhuo]

This happens on the version you built by yourself including this PR #490 ?

[Bryce-huang]

This happens on the version you built by yourself including this PR #490 ?

Yes, but it doesn't matter.

func getServingImage(fn *openfunction.Function) string {
	if fn.Status.Revision == nil ||
		fn.Status.Revision.ImageDigest == "" {
		return fn.Spec.Image
	}

	array := strings.Split(fn.Spec.Image, "@")
	repo := fn.Spec.Image
	if len(array) > 1 {
		repo = array[0]
	}

	return repo + "@" + fn.Status.Revision.ImageDigest
}

[Bryce-huang]

When the build is skiped, the Revision.ImageDigest still exist。

[Bryce-huang]

This problem will not occur if you specify the tag alone or use the source code to build alone.

[Bryce-huang]

Would it be better to not include the Revision.ImageDigest when calculating the serving hash?

func (r *FunctionReconciler) createServingSpec(fn *openfunction.Function) openfunction.ServingSpec {
	if fn.Spec.Serving == nil {
		return openfunction.ServingSpec{}
	}

	spec := openfunction.ServingSpec{
		Version:          fn.Spec.Version,
		Image:            getServingImage(fn),
		ImageCredentials: fn.Spec.ImageCredentials,
		ServingImpl:      *fn.Spec.Serving.DeepCopy(),
	}

	return spec
}

util.Hash(servingSpec)

[benjaminhuo]

Would it be better to not include the Revision.ImageDigest when calculating the serving hash?

func (r *FunctionReconciler) createServingSpec(fn *openfunction.Function) openfunction.ServingSpec {
	if fn.Spec.Serving == nil {
		return openfunction.ServingSpec{}
	}

	spec := openfunction.ServingSpec{
		Version:          fn.Spec.Version,
		Image:            getServingImage(fn),
		ImageCredentials: fn.Spec.ImageCredentials,
		ServingImpl:      *fn.Spec.Serving.DeepCopy(),
	}

	return spec
}

util.Hash(servingSpec)

@wanjunlei @wrongerror what do you think?

[wanjunlei]

I think the best solution is to clean up the revision when the image changes.