Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipCloseOnExitHook setting not persisted #217

Closed
wants to merge 2 commits into from
Closed

Fix skipCloseOnExitHook setting not persisted #217

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2020 •
edited by ghost

The first commit fixes #213

The second commit fixes the pre-shutdown action not being executed by maps opened with an existing file.

@dpisklov
Copy link
Contributor

@RobAustin can you review this? I'm not sure if this is something we want to do

@ghost ghost closed this Sep 19, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAustin RobAustin Awaiting requested review from RobAustin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChronicleMap flag skipCloseOnExitHook gets reset to false when loading map from and existing file
1 participant
@dpisklov