Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializableObjectTest is flappy #482

Open
nicktindall opened this issue May 31, 2022 · 3 comments
Open

SerializableObjectTest is flappy #482

nicktindall opened this issue May 31, 2022 · 3 comments
Labels

Comments

@nicktindall
Copy link
Contributor

This could be a genuine bug. The error is:

org.junit.ComparisonFailure: expected:<[2,[ 1, ]3]> but was:<[2,[1,]3]>
Expected :[2, 1, 3]
Actual   :[2,1,3]

When you attach a debugger to it, the LHS (source) is a LinkedList containing integers 2, 1, 3 and the RHS (target) is an ArrayList with a single string element 2,1,3

Oddly this behaviour seems non-deterministic, the test sometimes passes and sometimes fails.

@nicktindall
Copy link
Contributor Author

I suspect this test never ran under the old surefire. See the test history, it only starts running on 27/5 after the parent POM upgrade (which upgraded to surefire 3.0.0-M6)
https://teamcity.chronicle.software/test/-2175485830732454387?currentProjectId=Chronicle_ChronicleWire&expandTestHistoryChartSection=true

nicktindall added a commit that referenced this issue May 31, 2022
nicktindall added a commit that referenced this issue May 31, 2022
nicktindall added a commit that referenced this issue May 31, 2022
nicktindall added a commit that referenced this issue May 31, 2022
nicktindall added a commit that referenced this issue May 31, 2022
@alamar alamar added the flaky label Jun 3, 2022
peter-lawrey pushed a commit that referenced this issue Jun 6, 2022
peter-lawrey pushed a commit that referenced this issue Jun 6, 2022
peter-lawrey added a commit that referenced this issue Jun 6, 2022
* Remove addPadding(true) for useTextDocuments() #471

* Remove addPadding(true) for useTextDocuments() #471

* Improve handling of null in a sequence #471

* rename broken test - check behaviour of MethodIds in generated MethodReader

* sonar code smells

* deprecate VanillaMethodReaderBuilder.ignoreDefaults

* deprecate VanillaMethodWriterBuilder.methodWriterInterceptorReturns

* Updating to bom version 2.23ea44

* [maven-release-plugin] prepare release chronicle-wire-2.23ea9

* [maven-release-plugin] prepare for next development iteration

* Reverting back to bom version 2.23ea-SNAPSHOT

* Infinite message loop is possible with dontWriteHistoryForEventsWithNoOutput=false, closes ChronicleEnterprise/Chronicle-Services-Enterprise#330

* For functions with with primitive return values, make generated method writers behave the same as Proxy method writers

* Enhance ChainedMethodsTest for old-style proxies and also generated code

* un-Ignore tests

* Updating to bom version 2.23ea45

* [maven-release-plugin] prepare release chronicle-wire-2.23ea10

* [maven-release-plugin] prepare for next development iteration

* Reverting back to bom version 2.23ea-SNAPSHOT

* fix generated code method writer for generic return types

* Add methods (#474)

* update.

* update.

* Add replay method and tests.

* Added a test for the microservice

* Add Javadoc.

Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software>
Co-authored-by: Peter K Lawrey <peter.lawrey@higherfrequencytrading.com>

* Added a YamlTester interface to simplify running YAML based tests #475

* Added a YamlTester interface to simplify running YAML based tests #475

* Added a YamlTester interface to simplify running YAML based tests #475

* Added a YamlTester interface to simplify running YAML based tests #475

* Updating to bom version 2.23ea49

* [maven-release-plugin] prepare release chronicle-wire-2.23ea12

* [maven-release-plugin] prepare for next development iteration

* Reverting back to bom version 2.23ea-SNAPSHOT

* Updating parent POM (automated)

* Ignore some packages in SOT (#479)

* Ignore flappy test #482

* Ignore flappy test #482

* Remove delegate from generated MethodReader to proxied MethodReader. Support defaultParselet. Warnings for users of deprecated methods. Better reporting of method writer compilation failure. Warning that proxies will be dropped in x.25

* Updating parent POM (automated)

* Un-pin the binary-compatibility-enforcer version

* Flaky test fix

closes #486

* Remove addPadding(true) for useTextDocuments() #471

* Remove addPadding(true) for useTextDocuments() #471

Co-authored-by: Peter Lawrey <peter.lawrey@chronicle.software>
Co-authored-by: Jerry Shea <jerry.shea@chronicle.software>
Co-authored-by: hft-team-city <teamcity@chronicle.software>
Co-authored-by: Ivan Rakov <ivan.glukos@gmail.com>
Co-authored-by: Forough Goudarzi <forough.goudarzi@chronicle.software>
Co-authored-by: Per-Åke Minborg <minborg@speedment.com>
Co-authored-by: Nick Tindall <nick@tindall.id.au>
Co-authored-by: Ilya Kaznacheev <ilya.kaznacheev@chronicle.software>
@minborg minborg assigned RobAustin and unassigned minborg Jun 28, 2022
@RobAustin RobAustin removed their assignment Sep 12, 2022
@RobAustin
Copy link
Member

@nicktindall this has had a few commits... can it now be closed ?

@nicktindall
Copy link
Contributor Author

@RobAustin No there's actually been no work done on this, I think the "few commits" might just be my original ignore commits (there's two because I incorrectly did it using the JUnit 4 annotation on my first attempt) being pushed/cherry-picked to different branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants