Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] renaming of automatically-made dep update prs #184

Open
DerekNonGeneric opened this issue Dec 19, 2022 · 10 comments
Open

Comments

@DerekNonGeneric
Copy link
Member

DerekNonGeneric commented Dec 19, 2022

We have regularly been receiving dependency update requests from the following:

They each have their own way of titling their PRs and sometimes those titles match the first line of the commit message (other times they do not). The request is to fix these requests to match our needs.

@DerekNonGeneric
Copy link
Member Author

When we do make our package releases, our deployments should contain a CHANGELOG file, which will be retrieved by these services for providing information in their comments (or elsewhere).

@snyk-bot

  • TODO

@dependabot

  • TODO

@renovate-bot

@DerekNonGeneric
Copy link
Member Author

Renovate bumping a GitHub action: #196

How should we standardize these PR title renamings?

@DerekNonGeneric
Copy link
Member Author

This is going to have to be taken care of by @shellscape.

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Jan 17, 2023

So, what is a "Semantic PR" then? We're removing the app and will be defining the term here.

FTR: https://github.com/Ezard/semantic-prs being non-configurable means that it is now removed as it was unable to be used.

Would prefer using https://github.com/OpenINF/openinf-action-semantic-pull-request

@DerekNonGeneric
Copy link
Member Author

what is a "Semantic PR" then?

It would at least be composed of:

  1. Conventional PR Title
  2. Commit Message Body
    a. Description of Changes
    b. Commit Message Footer (trailers)

@DerekNonGeneric
Copy link
Member Author

@shellscape communicated to me that his time is too limited to commit to getting this worked out, so went ahead and unassigned, but hopefully he will be pinged on this to review our solution when ready.

@DerekNonGeneric
Copy link
Member Author

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Aug 17, 2023

Renovate now concludes PR titles w/ major (breakingly) changed updated deps w/ (major):

#513

But not always; perhaps only for the monorepos.

@DerekNonGeneric
Copy link
Member Author

Seems like the PR for bumping an action is going to have to be made by @OpenINFbot w/ proper automation code seeing as how Renovate is currently quite bad at naming the actual version being updated in the PR title.

See: OpenINF/docker-fisher#19
Refs: https://twitter.com/DerekNonGeneric/status/1723205132806918213

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Jan 1, 2024

That is just another one where there was missing noise; actually, is
a case needing perhaps another one more approval or a ci run!!

Refs: #664


that would ideally be built here, actually, via ci per pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants