馃彈馃敡锛歱olish off the tasking with prettify #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi there,
Great job on the changes so far! I noticed a few things that we need to address:
- In the
moon.ymlfile, theinputsandoutputsfor each task have been duplicated unintentionally. This could potentially cause issues. Please review and remove the duplicated lines.
Here's an example of what you need to fix:
verify-css:
command: moon run verify.css
inputs:
- '**/*.css'
inputs: # <-- This is duplicated
- '**/*.css'Please apply this fix to all tasks in the moon.yml file.
Keep up the good work!
DerekNonGeneric
requested changes
Aug 17, 2023
DerekNonGeneric
changed the title
DerekNonGeneric
added
question
DerekNonGeneric
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the tasking structure in the repository by implementing the changes proposed in this pull request. The current tasking situation is incomplete and uses the
npssolution, which is still functional but needs to be updated. The goal is to make the tasking structure more impressive and ready for org-wide adoption.Changes Made
moon.ymlfile to align with the proposed changes.build/tasks/format/format-md.mjsfile to ensure compatibility with the improved tasking structure..github/workflows/lint-and-test.ymlfile to work with the updated tasking structure.Checklist
npssolution and the CI workflow.Related Issues
Pull Request Type
Additional Information
Fixes #387.
To checkout this PR branch, run the following command in your terminal: