Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link hover/focus/active styling #1042

Open
fxedel opened this issue Sep 21, 2019 · 1 comment
Open

Link hover/focus/active styling #1042

fxedel opened this issue Sep 21, 2019 · 1 comment
Labels
component-ui Affects the user interface on the open-fixture-library.org website. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. priority-medium Great to have in the long run, but not urgent.

Comments

@fxedel
Copy link
Member

fxedel commented Sep 21, 2019

Currently, links only change their color slightly when hovering / focusing / clicking them. Hovering leads to a lighter color, which decreases readability.

Instead, links should be highlighted in the following way:

  • :link
    • color: keep previous link color (blue, in some places also grey), it must always be good readable against the current background
    • text-decoration: underline;
    • text-decoration-color: transparent;
    • text-underline-offset: 2px;
    • transition: Add text-decoration-color with same duration as existing transitions (color, fill, ...), e.g. 0.1s
  • :hover, :focus
    • text-decoration-color: currentColor;
    • This should be sufficient to communicate that this is a link
    • Check that transition of underline color works
  • :active
    • Set the link color (color and fill) to another color that is very good distinguishable from the normal link color, like orange-background (#ff9800).
    • Check that transition of link color works

This should, like before, only apply to inline text links. I.e. the download button, list/grid/card links, menu items, etc. should be excluded.

@fxedel fxedel added component-ui Affects the user interface on the open-fixture-library.org website. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. priority-medium Great to have in the long run, but not urgent. labels Sep 21, 2019
@fxedel fxedel added the hacktoberfest Good issue for users participating in the Hacktoberfest. label Sep 30, 2019
@FloEdelmann
Copy link
Member

FloEdelmann commented Oct 15, 2019

Also verify that the new colors have a good contrast in both light and dark theme. The Webhint tool can help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-ui Affects the user interface on the open-fixture-library.org website. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. priority-medium Great to have in the long run, but not urgent.
Projects
None yet
Development

No branches or pull requests

2 participants