Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QLC+ import improvements #1078

Open
7 of 10 tasks
fxedel opened this issue Oct 15, 2019 · 0 comments
Open
7 of 10 tasks

QLC+ import improvements #1078

fxedel opened this issue Oct 15, 2019 · 0 comments
Labels
component-plugin Affects one or more import or export plugins. difficulty-medium Some research is needed before implementation, or implementation is time-consuming. hacktoberfest Good issue for users participating in the Hacktoberfest. priority-medium Great to have in the long run, but not urgent.

Comments

@fxedel
Copy link
Member

fxedel commented Oct 15, 2019 •
edited

  • For properties like bulb type or lens name (or also DMX connector?), the QLC+ import plugin shouldn't import the "Other" value since almost all QLC+ fixtures have this as default, so it doesn't give us any information. Instead, it should simply omit these properties.
  • Don't crash if there's no Physical (e.g. Generic Desk Channel)
  • Search for CW/CCW in WheelSlotRotation
  • Remove "mode" from mode names
  • Import new manufacturers, don't warn for existing ones.
  • Handle "Blackout"
  • Prism speed
  • Search for slow…fast in Effect capabilities
  • Fix "effectName": ""
  • Gobo channel type parser: Check for rotation in channel name
@fxedel fxedel added component-plugin Affects one or more import or export plugins. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. priority-medium Great to have in the long run, but not urgent. labels Oct 15, 2019
@fxedel fxedel changed the title QLC+: Don't import "Other" QLC+ import improvements Mar 26, 2020
@fxedel fxedel mentioned this issue Mar 27, 2020
Merged
@fxedel fxedel added difficulty-medium Some research is needed before implementation, or implementation is time-consuming. and removed difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-plugin Affects one or more import or export plugins. difficulty-medium Some research is needed before implementation, or implementation is time-consuming. hacktoberfest Good issue for users participating in the Hacktoberfest. priority-medium Great to have in the long run, but not urgent.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fxedel