Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☑ Help with reviewing new fixtures #2429

Open
FloEdelmann opened this issue Feb 22, 2022 · 0 comments
Open

☑ Help with reviewing new fixtures #2429

FloEdelmann opened this issue Feb 22, 2022 · 0 comments
Labels
difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. help wanted More information/insights or implementation wanted from others.

Comments

@FloEdelmann
Copy link
Member

There are a lot of pull requests for new fixtures that are not yet reviewed and merged. Reviewing them (and maybe fixing smaller issues) helps get this number down and the number of fixtures in OFL up!

See the step-by-step instructions for fixture reviews:

These are the steps that take the longest when reviewing a fixture:

  1. Checking whether at least 3 links are present. Otherwise, finding suitable links.
    • link to a manual PDF containing all DMX modes
    • link to a product page on the official manufacturer website
    • link to a YouTube or Vimeo video that showcases or explains the fixture
  2. Checking whether all DMX modes from the manual are included in the fixture definition.
  3. Checking whether all DMX modes' channels from the manual are included in the fixture definition.
  4. Checking whether all DMX channels' capabilities from the manual are included in the fixture definition.
    If you could go through some PRs with the new-fixture label and comment on them with the results of those checks, that would help immensely. Thank you already :)

For the fixtures passing these tests, these are some common tasks that often need to be fixed:

  • replace capability type StrobeSpeed with ShutterStrobe where that one fits better
  • replace capability type Generic with Maintenance where that one fits better
  • rename modes that have no name in the manual to the usual 5-channel/5ch format
  • link to an English manual / product page (if one exists) instead of one in another language

Pull requests with these fixes against the original fixture pull requests (see e.g. #2023) are highly appreciated!

@FloEdelmann FloEdelmann added difficulty-easy Implementation is relatively straighforward. help wanted More information/insights or implementation wanted from others. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. labels Feb 22, 2022
@FloEdelmann FloEdelmann pinned this issue Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest. help wanted More information/insights or implementation wanted from others.
Projects
None yet
Development

No branches or pull requests

1 participant