Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFL ddf3 download failed #3637

Open
xMGamerPlex1 opened this issue Nov 20, 2023 · 8 comments
Open

OFL ddf3 download failed #3637

xMGamerPlex1 opened this issue Nov 20, 2023 · 8 comments
Labels
bug Something doesn't work as intended. component-plugin Affects one or more import or export plugins.

Comments

@xMGamerPlex1
Copy link

Hello everyone,
I have tried to download the library for DMXControll3. But no matter which browser I use, I always get the same error message. See screenshot below. Can someone please help me.

Thank you in advance.

Screenshot

@kengruven
Copy link
Contributor

I can't help with fixing this, but I can confirm that this download (and only this one) consistently gives this error.

@FloEdelmann
Copy link
Member

It would be helpful to know for which specific fixture the DDF3 download fails, this one is then causing the "all fixtures" download to fail, too.

@FloEdelmann FloEdelmann added bug Something doesn't work as intended. component-plugin Affects one or more import or export plugins. labels Jan 2, 2024
@kengruven
Copy link
Contributor

I clicked the DDF3 download link on a bunch of individual fixtures, and they all worked. There doesn't seem to be any way to download any subset of fixtures between "one" and "all" so there's no easy way to do a bisection just by clicking on the webpage.

Could we add the filename of the failed fixture to this error message? I don't know any Vue and very little JS but that seems like a quick-n-dirty way to narrow down the problem space.

(Or I suppose I could learn how to install OFL and log exceptions myself...)

@FloEdelmann
Copy link
Member

Could we add the filename of the failed fixture to this error message? I don't know any Vue and very little JS but that seems like a quick-n-dirty way to narrow down the problem space.

That makes sense anyway. I see what I can do.

(Or I suppose I could learn how to install OFL and log exceptions myself...)

Would be good regardless 😉
But feel free to contribute however you like best 🙂

@FloEdelmann
Copy link
Member

Alright, #3969 is deployed, and the DMXControl3 export seems to fail for cameo/root-par-6's 4ch1 fixture mode.

@kengruven
Copy link
Contributor

Two general questions (which don't seem to be fatal errors in other fixtures so probably aren't the smoking gun here):

  • Is it valid to have a channel full of ShutterStrobe capabilities, and also:
        {
          "dmxRange": [128, 250],
          "type": "StrobeSpeed",
          "speedStart": "1Hz",
          "speedEnd": "20Hz"
        }

or does this one need to be type=ShutterStrobe, shutterEffect=Strobe to match the rest?

  • Is it valid to have a type=ColorPreset with no colors/colorsStart/colorsEnd?

Also, the automatic-gray functionality (in ddf3-functions.js getColor()) is pretty weird but also doesn't seem to be causing any other fixture export to abort.

@kengruven
Copy link
Contributor

kengruven commented May 18, 2024

Full stack trace:

TypeError: Cannot read properties of undefined (reading 'value')
    at Object.getXmlGroup (open-fixture-library/plugins/dmxcontrol3/ddf3-function-groups.js:15:43)
    at groupXmlFunctions (open-fixture-library/plugins/dmxcontrol3/export.js:199:32)
    at addFunctions (open-fixture-library/plugins/dmxcontrol3/export.js:120:5)
    at exportFixtureMode (open-fixture-library/plugins/dmxcontrol3/export.js:64:3)
    at Object.exportFixtures (open-fixture-library/plugins/dmxcontrol3/export.js:28:32)
    at downloadFixtures (open-fixture-library/ui/api/download.js:28:32)

@kengruven
Copy link
Contributor

In channel "Strobe Multifunctional", making the change

-          "type": "StrobeSpeed",
+          "type": "ShutterStrobe",
+          "shutterEffect": "Strobe",

allows it to complete without error. But other fixtures with one StrobeSpeed amongst some ShutterStrobe capabilities (like chauvet-professional/colorado-1-solo) work fine as-is, so it's not as simple as that.

This seems to be the only fixture in all of OFL which exhibits this problem.

kengruven added a commit to kengruven/open-fixture-library that referenced this issue May 18, 2024
Since StrobeSpeed "doesn't activate strobe directly", this is certainly what was intended.

This will hide the effects of bug OpenLightingProject#3637, but doesn't fix the root problem there, or dozens of other fixtures which make this same mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as intended. component-plugin Affects one or more import or export plugins.
Projects
None yet
Development

No branches or pull requests

3 participants