Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Add links to fixtures #578

Open
fxedel opened this issue Aug 10, 2018 · 0 comments
Open

馃寪 Add links to fixtures #578

fxedel opened this issue Aug 10, 2018 · 0 comments
Labels
component-fixture Affects one or more existing fixture definitions. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest.

Comments

@fxedel
Copy link
Member

fxedel commented Aug 10, 2018

With Schema 9.0.0, is it possible to add multiple links of specified types to fixtures, like so:

{
  // ...
  "links": {
    "manual": [
      "https://example.com/downloads/some-fixture-manual.pdf"
    ],
    "productPage": [
      "https://example.com/products/some-fixture"
    ],
    "video": [
      "https://www.youtube.com/watch?v=dQw4w9WgXcQ"
    ],
  },
  // ...
}

Having at least one manual, one product page and one video per fixture would be very helpful. Small pull requests to only add a single link are appreciated as well.

@fxedel fxedel added component-fixture Affects one or more existing fixture definitions. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. labels Aug 10, 2018
fxedel added a commit that referenced this issue Aug 10, 2018
@FloEdelmann FloEdelmann added hacktoberfest Good issue for users participating in the Hacktoberfest. and removed hacktoberfest Good issue for users participating in the Hacktoberfest. labels Oct 5, 2018
@FloEdelmann FloEdelmann pinned this issue Dec 19, 2019
@FloEdelmann FloEdelmann changed the title Add missing product pages to fixtures 馃寪 Add missing product pages to fixtures Jul 6, 2020
@FloEdelmann FloEdelmann changed the title 馃寪 Add missing product pages to fixtures 馃寪 Add links to fixtures Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-fixture Affects one or more existing fixture definitions. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest.
Projects
None yet
Development

No branches or pull requests

2 participants