Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for src/grid-api-client.js #141

Open
1 of 6 tasks
tcp opened this issue May 27, 2020 · 3 comments
Open
1 of 6 tasks

Write tests for src/grid-api-client.js #141

tcp opened this issue May 27, 2020 · 3 comments
Assignees
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! hacktoberfest-accepted Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Milestone

Comments

@tcp
Copy link

tcp commented May 27, 2020

Description

src/grid-api-client.js

Type of Test

  • Unit test (e.g. checking a loop, method, or function is working as intended)
  • Integration test (e.g. checking if a certain group or set of functionality is working as intended)
  • Regression test (e.g. checking if by adding or removing a module of code allows other systems to continue to function as intended)
  • Stress test (e.g. checking to see how well a system performs under various situations, including heavy usage)
  • Performance test (e.g. checking to see how efficient a system is as performing the intended task)
  • Other

Expected Behavior

We expect this file to be covered completely by tests. It's not intended to test feature-related functionality but is instead intended to test the file in isolation.

Additional Context

None

@tcp tcp added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase labels May 27, 2020
@choilmto
Copy link

Hi! I'm interested in working on this ticket. What do I need to know about testing in this repo for my pull request(s)?

@cereallarceny cereallarceny added this to the 0.2.0 milestone Jul 1, 2020
@cereallarceny
Copy link
Member

Fantastic @choilmto ! Go ahead and get started on this issue. For PR’s, just fork the repo and push to your cloned repo, you can make a PR from there.

@vvmnnnkv
Copy link
Member

vvmnnnkv commented Jul 2, 2020

@choilmto feel free to ask questions in #lib_syft_js channel in Openmined slack as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! hacktoberfest-accepted Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Development

No branches or pull requests

5 participants