Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new colours compatible with UI themes #19870

Open
kyphii opened this issue Apr 7, 2023 · 1 comment · May be fixed by #21991
Open

Make new colours compatible with UI themes #19870

kyphii opened this issue Apr 7, 2023 · 1 comment · May be fixed by #21991
Labels
enhancement An improvement to an existing feature (no alteration). refactor A task that will improve code readability, without changing outcome.

Comments

@kyphii
Copy link
Contributor

kyphii commented Apr 7, 2023

Creating some issues for new colors follow-up so anyone can take them up.

UI Themes don't currently support the new colors, as the UI theme data structure stores some flags in the upper bits of the color fields. These will need to be refactored out. Currently there's a workaround to map the new colors to base game colors until this can be done.

An open question is how we'll be able to handle saved UI themes that have this flags setup, as there isn't a versioning system in place for UI themes.
@IntelOrca
Copy link
Contributor

If you add a version number, then you can assume no version number means version 1.

@Gymnasiast Gymnasiast added enhancement An improvement to an existing feature (no alteration). refactor A task that will improve code readability, without changing outcome. labels Mar 1, 2024
@Gymnasiast Gymnasiast changed the title New Colors Follow-Up: Make new colors compatible with UI themes Make new colours compatible with UI themes May 9, 2024
@Gymnasiast Gymnasiast linked a pull request May 9, 2024 that will close this issue
Close #19870: Make new colours compatible with UI themes #21991
Open
@Gymnasiast Gymnasiast mentioned this issue May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement to an existing feature (no alteration). refactor A task that will improve code readability, without changing outcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #19870: Make new colours compatible with UI themes Gymnasiast/OpenRCT2
3 participants
@Gymnasiast @IntelOrca @kyphii