Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom sprites broken for custom objects #22009

Open
spacek531 opened this issue May 10, 2024 · 0 comments
Open

Zoom sprites broken for custom objects #22009

spacek531 opened this issue May 10, 2024 · 0 comments
Labels
bug Something went wrong.

Comments

@spacek531
Copy link
Contributor

spacek531 commented May 10, 2024

Operating System

Windows 10 64-bit

OpenRCT2 build

OpenRCT2 v0.4.10

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

This issue has to do with park objects and/or asset packs

Describe the issue

When experimenting with zoom sprites yesterday, I could not get them to work. I believe I have discovered why, and the issue is twofold:

  • There is a struct handoff between ImageImportMeta and Image in ImageImporter::Import that overwrites the meta's flags, dropping the flag for using zoom offset.
  • The game unsets the zoom offset flag in the ImageTable::RequiredImage G1Element constructor overload.
  • The game does not populate the pointer in ImageTable::RequiredImage. It works for CSG and G1 images, apparently, but I'm having trouble finding that codepath.

Steps to reproduce

  1. Create a JSON that utilizes zoom sprites
  2. Zoom sprites are loaded but unused because of issues above

Attachments

No response

@spacek531 spacek531 added the bug Something went wrong. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

1 participant