Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify AlertCondition.threshold #137

Open
kenfinnigan opened this issue May 24, 2022 · 0 comments
Open

Clarify AlertCondition.threshold #137

kenfinnigan opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kenfinnigan
Copy link
Collaborator

Summary

Currently AlertCondition.threshold is defined as a number in the spec but an int in the Oslo struct.

I can see use cases of wanting to threshold on more than 100%, 200%, 300%, etc, such as 150%.

I don't know if "number" in our definition would support a value of 1.5, or whether it needs to change.

Once we've clarified the meaning in the spec, a follow-on issue would be to adjust the Oslo structs to align with it.

Possible fixes

Field is a float to support decimal values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenSLO roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenfinnigan