Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define schema in .cue? #20

Open
embano1 opened this issue May 30, 2021 · 5 comments
Open

Define schema in .cue? #20

embano1 opened this issue May 30, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@embano1
Copy link

embano1 commented May 30, 2021

I think defining the schema using https://cuelang.org/ would bring a lot of benefits at this early stage of the project, e.g.:

  • Simplified configuration/schema generation via flexible data and schema expression language
  • Constrains, eg. bounds (numbers), optional/required/default fields, etc.
  • Import/export from/to standard formats, incl. CRD/OpenAPI

Related: OpenSLO/oslo#23
@ian-bartholomew ian-bartholomew added the enhancement New feature or request label Jun 8, 2021
@ian-bartholomew
Copy link
Contributor

@embano1 I think that this is a really interesting idea. PRs are welcome for this if anyone wants to pick it up. I think keeping them in this repo, for now, is fine, and we can move them into their own repo if we decide it's appropriate later.

Thanks!

@ian-bartholomew ian-bartholomew mentioned this issue Jun 8, 2021
Closed
@embano1 embano1 mentioned this issue Jun 11, 2021
Open
3 tasks
@embano1
Copy link
Author

embano1 commented Jun 11, 2021

@ian-bartholomew started working on a prototype schema as proposal. Will file PR once I have all fields covered.

@ian-bartholomew
Copy link
Contributor

@embano1 thats amazing, thank you!

embano1 pushed a commit to embano1/OpenSLO that referenced this issue Jun 14, 2021
WIP: Define schema with cue
0d19426 
Closes: OpenSLO#20
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 mentioned this issue Jun 14, 2021
Closed
4 tasks
embano1 pushed a commit to embano1/OpenSLO that referenced this issue Jun 14, 2021
WIP: Define schema with cue
e52c778 
Closes: OpenSLO#20
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1
Copy link
Author

embano1 commented Jun 29, 2021

Created a WIP PR with couple of questions where I'm unclear about the SLO spec.

@ian-bartholomew
Copy link
Contributor

@embano1 got it, thanks!

@ian-bartholomew ian-bartholomew added this to the v1.0.0 milestone Jul 14, 2021
@ian-bartholomew ian-bartholomew added the help wanted Extra attention is needed label Jul 15, 2021
@embano1 embano1 mentioned this issue Jan 23, 2022
Open
kenfinnigan pushed a commit to kenfinnigan/OpenSLO that referenced this issue Apr 4, 2022
Define OpenSLO spec as Go structs.
bd3923b 
Can be an alternative to OpenSLO#20 and OpenSLO#87, or as a precursor to them.

Changes:
 - Moved `v1alpha` structs from oslo to here
 - Created `v1beta1` structs to represent the current state of the spec
 - Removed `Service` from `v1beta` as it is not used, as far as I could
   tell
 - Renamed `kind` to `type` for `AlertCondition` to prevent confusion
   with `Kind` which has a different meaning
@kenfinnigan kenfinnigan mentioned this issue Apr 4, 2022
Closed
@programmer04 programmer04 mentioned this issue Apr 25, 2022
Open
@programmer04 programmer04 removed this from the v1.0.0 milestone Jun 28, 2022
@kenfinnigan kenfinnigan mentioned this issue Mar 9, 2023
Open
fourstepper pushed a commit to fourstepper/OpenSLO that referenced this issue Jun 27, 2023
@fourstepper
WIP: Define schema with cue
176b393 
Closes: OpenSLO#20
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@nieomylnieja nieomylnieja mentioned this issue Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Define schema with cue embano1/OpenSLO
3 participants
@ian-bartholomew @programmer04 @embano1