Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid instead of total #262

Open
alexewerlof opened this issue May 15, 2024 · 1 comment
Open

Use valid instead of total #262

alexewerlof opened this issue May 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alexewerlof
Copy link

Reading v2alpha1 spec I see the total is still there from v1.

Maybe it's a nit, but I suggest using valid instead for reasons that I've explained here.

Essentially, the formula for SLI is:

good / valid x 100

The distinction between valid and total enables the users to see the possibility to scope their optimization effort to what they see in their area of responsibility and control as well as preventing false alerts for things that are clearly not.

@alexewerlof alexewerlof added the bug Something isn't working label May 15, 2024
@nieomylnieja
Copy link
Member

Hey @alexewerlof, thanks for bringing this up :) (and the other issue)
We're planning next community meeting between 3th and 7th of June (18:00 UTC).
You can either let me know here which day(s) suit you best or vote directly on our Slack, there's an invite link at the bottom of https://openslo.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants