Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Raids Screen #17

Open
nobrayner opened this issue Jan 21, 2021 · 13 comments
Open

All Raids Screen #17

nobrayner opened this issue Jan 21, 2021 · 13 comments
Assignees
Labels
Quest: Main Main Storyline Quest for current Dungeon Type: Enhancement Extensions to current feature or functionality
Milestone

Comments

@nobrayner
Copy link
Contributor

nobrayner commented Jan 21, 2021

Can be switched between the "Active" tab, and "Completed" tab. Active tab only fetches Raid's with the "active" status - Completed tab only gets "completed" status.

The Raids list is shown in newest to oldest order.

Something to think about, is paginating the completed raids, so we aren't hammering the DB or slowing the page down.

Wireframe(s)

All Raids - Completed
All Raids - Active

https://www.figma.com/file/oOFsQ2ecdyYjnK91yOKPDR/Raid-Guild-Site-Planning?node-id=27%3A0

@nobrayner nobrayner added CTA: Help Wanted CALL TO ACTION: Rally to Aid a fellow Raid Member!!! Type: Enhancement Extensions to current feature or functionality Quest: Main Main Storyline Quest for current Dungeon labels Jan 21, 2021
@nobrayner
Copy link
Contributor Author

This isn't just a "Implement this exactly" - if anyone has a suggestion, or while working on it an improvement or idea comes along... Do it! If it is super drastic and you aren't sure, chat about it! This is just a baseline to get us all started

@nobrayner nobrayner added this to the Raid Stats v1 milestone Jan 21, 2021
@tigerabrodi
Copy link
Contributor

tigerabrodi commented Jan 23, 2021

@nobrayner I think since styling at the moment is not necessary, this is awesome 🙌

I think it would be great to see some more info for the different raids, i.e. time, amount of people who contributed, etc. not too detailed but perhaps a bit of information, what do you think?
An example could be a number with some icon, indicating how many contributed to a particular raid. 🤷‍♂️

@ziedtouibi
Copy link

Hey guys, what are the screens/pages the website will have?

@tigerabrodi
Copy link
Contributor

tigerabrodi commented Jan 23, 2021

@ziedtouibi I recommend opening a new issue for this and bringing it up in Discord, about the routes + pages we want to have for our website 💯.

@nobrayner
Copy link
Contributor Author

nobrayner commented Jan 23, 2021

What are the screens/pages the website will have?

@ziedtouibi couldn't tell you at this point! 😅 This will more happen one feature at a time, and improvements will be made accross the board as we go.

@tigerabrodi
Copy link
Contributor

@nobrayner Defo! @JacobMGEvans also shared this with me, which I probably missed somehow https://github.com/OpenSourceRaidGuild/website/milestones 🔥

I think we can use those milestones as our "focus" point, looks nice btw!! 💪

@YPAzevedo
Copy link
Contributor

@nobrayner are the labels going to be colored? like complete, open, in progress.

@nobrayner
Copy link
Contributor Author

The "Completed" label was based on there only being two options: In Progress and Completed. I am actually thinking it may be better to change up this wireframe, and have two lists: the "Active" raids, and the "Completed" raids. Then there is no need for the status indicator, or filtering between them.

Reasoning: The current state of the Guild will only have a few active raids at a time (if more than one at all). Another approach could be tabs - @YPAzevedo what do you think?

@YPAzevedo
Copy link
Contributor

@nobrayner I like the idea of separating the two, tabs are interesting, with the active tab being the first one, right? Then if we end up having more statuses we can move to a tag/pill approach for filtering

@JacobMGEvans
Copy link
Member

JacobMGEvans commented Jan 25, 2021

Thoughts?
Better Raid names
Quest & Raid Boss is the current Raid Name

Mystic Ice HospitalRun
-> Main Quest & Raid Boss: Convert Enzyme to React Testing LIbrary

@nobrayner
Copy link
Contributor Author

@YPAzevedo I have updated the main issue body with new wireframes.

Were you planning on taking this one up?

@nobrayner
Copy link
Contributor Author

I really want better raid names - that's for sure. But I would want them to be randomly generated, somehow... Maybe worth a separate issue for that, @JacobMGEvans ?

@datner
Copy link
Contributor

datner commented Jan 30, 2021

I can try to tackle this

@datner datner self-assigned this Jan 30, 2021
@nobrayner nobrayner removed the CTA: Help Wanted CALL TO ACTION: Rally to Aid a fellow Raid Member!!! label Jan 30, 2021
@JacobMGEvans JacobMGEvans linked a pull request Feb 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quest: Main Main Storyline Quest for current Dungeon Type: Enhancement Extensions to current feature or functionality
Projects
No open projects
6 participants