Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up new Sentinels with event and/or function conditions, fail silently when the ABI does not match #176

Open
asgeir-s opened this issue Oct 27, 2022 · 0 comments

Comments

@asgeir-s
Copy link
Contributor

When setting up new Sentinels with event and/ or function conditions, the condition setup will fail silently (it will not filter based on the event/function conditions) if:

  • No ABI is provided.
  • If the event or function is not percent in the ABI.
  • If only some functions or events are percent.

This seems to be the root of the issue:

events: abiEvents.map((event) =>

Perhaps the following checks could be added:

  1. Throw an error if event or function conditions are percent but no ABI.
  2. Throw an error if any of the function or event conditions (signatures) are not percent in the provided ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant