Skip to content

GovernorVotesQuorumFraction updates to quorum may affect past defeated proposals

High
frangio published GHSA-xrc4-737v-9q75 Jul 28, 2022

Package

npm @openzeppelin/contracts (npm)

Affected versions

>= 4.3.0 < 4.7.2

Patched versions

4.7.2
npm @openzeppelin/contracts-upgradeable (npm)
>= 4.3.0 < 4.7.2
4.7.2

Description

Impact

This issue concerns instances of Governor that use the module GovernorVotesQuorumFraction, a mechanism that determines quorum requirements as a percentage of the voting token's total supply. In affected instances, when a proposal is passed to lower the quorum requirement, past proposals may become executable if they had been defeated only due to lack of quorum, and the number of votes it received meets the new quorum requirement.

Analysis of instances on chain found only one proposal that met this condition, and we are actively monitoring for new occurrences of this particular issue.

Patches

This issue has been patched in v4.7.2.

Workarounds

Avoid lowering quorum requirements if a past proposal was defeated for lack of quorum.

References

#3561

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at security@openzeppelin.com.

Severity

High

CVE ID

CVE-2022-31198

Weaknesses

No CWEs