Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack Command !search #72

Open
apex-omontgomery opened this issue May 5, 2019 · 16 comments
Open

Slack Command !search #72

apex-omontgomery opened this issue May 5, 2019 · 16 comments
Labels
general: good first issue Good for newcomers priority: low This is an issue that is fine sitting for a while project: rewrite This issue applies to the rewrite of Pybot status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: feature Issue involves adding new functionality that doesn't currently exist

Comments

@apex-omontgomery
Copy link
Member

!search how to print line java will look through stackoverflow or google for results and then post a link.
@apex-omontgomery apex-omontgomery added the general: good first issue Good for newcomers label May 5, 2019
@the-bose
Copy link

the-bose commented Oct 1, 2019

Hello, I would like to work on this

@kylemh kylemh added the general: hacktoberfest Issue is a good fit for Hacktoberfest label Oct 1, 2019
@utkryuk
Copy link

utkryuk commented Oct 7, 2019

I would like to take this task.

@AllenAnthes AllenAnthes removed the general: hacktoberfest Issue is a good fit for Hacktoberfest label Dec 29, 2019
@kylemh kylemh added the general: hacktoberfest Issue is a good fit for Hacktoberfest label Oct 1, 2020
@harjyotbagga
Copy link

Hey, I would like to try and resolve this issue, by adding the !search command. Request you to assign it to me.
Since I'm just starting out with open source, it'd be great if you could give me a week's time, to solve this issue with a PR. 😄

@aaron-junot
Copy link
Member

@harjyotbagga We'd love the help. If you have any questions, let us know!

@harjyotbagga
Copy link

Thanks for the positive response! 😄 I've started working on it. Please assign this issue to me. I'll get back in a couple of days.

@harjyotbagga
Copy link

@aaron-suarez I needed a bit of help.
I followed all the steps in the readme.

  • Made a slack app and integrated it into my workspace.
  • Updated the pybot.env variables, using the Secret code and the O-Auth token from the Slack app.
  • Installed all dependencies and was able to successfully run the bot on the localhost.
  • Made my localhost open to the public using ngrok.
  • To test a few commands, I added the command in slash-commands on the slack API, setting the URL as https://54bac023ae26.ngrok.io.

After which I tried running the command on slack, giving me a "dispatch error" and "401 Unauthorized" on my terminal. Pl note, I have verified the auth tokens and there is no issue there. I would appreciate some guidance from your end.

[https://github.com/slackapi/bolt-js/issues/579 ] A similar issue has been reported here.

pybot-term

pybot-commands

pybot-slack

@aaron-junot
Copy link
Member

Oh weird, so the bot itself is producing a 401? What happens when you hit it manually (with like Postman or curl, rather than going through slack)?

@harjyotbagga
Copy link

harjyotbagga commented Oct 7, 2020 •
edited

I have tried sending the request via Postman. I made an OAuth2.0 authentication token by reading the Slack App docs and sent a POST request to https://df94f7be0da7.ngrok.io/slack/commands?command=roll after I updated the slash command request URL in the slack app dashboard.
I got a 500 Server Internal Error that looks something like,
pybot-err
I am not able to understand how do I fix this internal error. I am getting no error on the python terminal when I send the command via slack, but the response states /roll failed with the error "dispatch_failed" and the the ngrok terminal still says 401 Unauthorized.
Any guidance would be more than helpful.

@aaron-junot
Copy link
Member

If you join our slack team at https://operationcode.org/join I'd be happy to set up a slack call and pair with you on troubleshooting it. I don't know from just looking at it what the problem could be.

This was referenced Oct 8, 2020
Closed
Closed
@aaron-junot
Copy link
Member

I just got the /roll failed with the error "dispatch_failed" error on my slack workspace as well... I'm wondering if this warrants an issue. @AllenAnthes when you get a chance can you check and see if you also get this error?

@aaron-junot
Copy link
Member

Note, it does not happen on prod right now (which is good). I wonder if it's something that we introduced recently...

@aaron-junot
Copy link
Member

I think it might be related to #227. @LivingInSyn did you ever see this "dispatch_failed" situation when you were working on the issue?

@LivingInSyn
Copy link
Contributor

LivingInSyn commented Oct 9, 2020 via email

@aaron-junot
Copy link
Member

I noticed that we merged that to master directly and our branches are based on staging, so it's true, it's not due to #227... Perhaps another recent change. I'll dig deeper when I have a chance, I'm not sure I'll be able to right now

@aaron-junot
Copy link
Member

I was able to resolve it by making sure that the right ngrok url was in, and that my bot was running correctly. So I'm thinking it might be an issue like that @harjyotbagga

@JudsonStevens JudsonStevens removed the general: hacktoberfest Issue is a good fit for Hacktoberfest label Aug 18, 2021
@aaron-junot aaron-junot added the priority: medium This is an issue that has some urgency but isn't an emergency label Aug 18, 2021
@aaron-junot aaron-junot added general: hacktoberfest Issue is a good fit for Hacktoberfest priority: low This is an issue that is fine sitting for a while and removed priority: medium This is an issue that has some urgency but isn't an emergency labels Sep 29, 2021
@JudsonStevens
Copy link
Collaborator

We'll be implementing this based on previous work into the new rewritten bot. This one is fairly low priority though so may take a bit.

@JudsonStevens JudsonStevens added project: rewrite This issue applies to the rewrite of Pybot status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box labels Jan 1, 2022
@JudsonStevens JudsonStevens added type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: feature Issue involves adding new functionality that doesn't currently exist labels Jan 1, 2022
@JudsonStevens JudsonStevens changed the title Slack command !search Slack Command !search Jan 2, 2022
@JudsonStevens JudsonStevens removed the general: hacktoberfest Issue is a good fit for Hacktoberfest label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
general: good first issue Good for newcomers priority: low This is an issue that is fine sitting for a while project: rewrite This issue applies to the rewrite of Pybot status: awaiting acceptance Issue has not been accepted - it may need documentation, discussion, or a decision - the ice box type: code change Issue requires changes to the code base type: documentation Issue requires a change to the current documentation of the codebase or product type: feature Issue involves adding new functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Resolving Issue #72] Implemented !search functionality. harjyotbagga/operationcode-pybot
9 participants
@aaron-junot @LivingInSyn @kylemh @apex-omontgomery @AllenAnthes @the-bose @JudsonStevens @utkryuk @harjyotbagga