feat(sandbox): kill child workers gracefully #1802
Merged
+159
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielCastro
force-pushed
the
feat/kill-sandboxed-workers-gracefully
branch
from
e55f0d1 to
fc19340
Compare
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 15, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
force-pushed
the
feat/kill-sandboxed-workers-gracefully
branch
4 times, most recently
from
01c77f4 to
fb4ecb9
Compare
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 21, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 21, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 21, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 21, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 21, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
GabrielCastro
added a commit
to GabrielCastro/bullmq
that referenced
this pull request
Jul 23, 2020
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Worker#close now also kills the workers and waits for them to close This is the same feature as OptimalBits/bull#1802
Properly handle SIGTERM in the child workers by waiting for the current job to exit, then exiting cleanly. Queue.close now also kills the workers and waits for them to close
GabrielCastro
force-pushed
the
feat/kill-sandboxed-workers-gracefully
branch
2 times, most recently
from
1acb258 to
bb26001
Compare
|
@manast This is the same change as taskforcesh/bullmq#243 would it be possible to back-port it here too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle SIGTERM in the child workers by waiting for the current
job to exit, then exiting cleanly.
Queue.close now also kills the workers and waits for them to close