Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Client not exported #55

Closed
statusunknown418 opened this issue Feb 17, 2023 · 18 comments
Closed

Query Client not exported #55

statusunknown418 opened this issue Feb 17, 2023 · 18 comments

Comments

@statusunknown418
Copy link

statusunknown418 commented Feb 17, 2023

So I've just created a base app with trpc enabled and I'm getting an error saying.

Screenshot 2023-02-17 at 13 27 16

I think the new QueryClient should either be trpc.useContext() or QueryClient from @tanstack/solid-query

@OrJDev
Copy link
Owner

OrJDev commented Feb 17, 2023

Oh i see, did you say yes when it asked you if you want to use ssr with trpc?

@statusunknown418
Copy link
Author

Yep, I think the config changes for ssr

@OrJDev
Copy link
Owner

OrJDev commented Feb 17, 2023

Yep, I think the config changes for ssr

@tanstack/solid-query shouldn't be installed when choosing ssr, can you create a repo with the full output files?

@OrJDev
Copy link
Owner

OrJDev commented Feb 17, 2023

Yep, I think the config changes for ssr

@tanstack/solid-query shouldn't be installed when choosing ssr, can you create a repo with the full output files?

https://github.com/OrJDev/create-jd-app/blob/main/src/installers/tRPC/index.ts#L43

@statusunknown418
Copy link
Author

You mean selecting all the installers and enabling ssr?

@OrJDev
Copy link
Owner

OrJDev commented Feb 17, 2023

You mean selecting all the installers and enabling ssr?

No like, create a repo with what create jd app created for you

@statusunknown418
Copy link
Author

sure, it's here https://github.com/AlvaroAquijeDiaz/jd-app-demo

@OrJDev
Copy link
Owner

OrJDev commented Feb 17, 2023

sure, it's here https://github.com/AlvaroAquijeDiaz/jd-app-demo

rm -rf node_modules 
pnpm install

Would this work for you

@statusunknown418
Copy link
Author

sure, it's here https://github.com/AlvaroAquijeDiaz/jd-app-demo

rm -rf node_modules 
pnpm install

Would this work for you

error still showing up though

@OrJDev
Copy link
Owner

OrJDev commented Feb 18, 2023

sure, it's here https://github.com/AlvaroAquijeDiaz/jd-app-demo

rm -rf node_modules

pnpm install

Would this work for you

error still showing up though

That is weird because @tanstack/solid-query doesn't even seem to appear in package.json, could you try using different package manager, like npm.

rm -rf node_modules
npm install

Also make sure to restart the ts server after that

@OrJDev
Copy link
Owner

OrJDev commented Feb 19, 2023

Hey there,
Could you give an update on that?

@statusunknown418
Copy link
Author

Hey, I'll be looking at it tomorrow, haven't had the opportunity yet

@statusunknown418
Copy link
Author

Hey there, Could you give an update on that?

Screenshot 2023-02-20 at 17 39 11

got this error while trying to use npm, weird

@statusunknown418
Copy link
Author

using --legacy-peer-deps solves both issues

@statusunknown418
Copy link
Author

however is there a reason why @adeora/solid-query is used instead of the plain @tanstack/solid-query? or the useContext shipped with tRPC v10?

@OrJDev
Copy link
Owner

OrJDev commented Feb 25, 2023

however is there a reason why @adeora/solid-query is used instead of the plain @tanstack/solid-query? or the useContext shipped with tRPC v10?

Aryan is the guy who created solid query, this is a patched package that supports server side rendering. The normal solid query doesn't support that

@OrJDev
Copy link
Owner

OrJDev commented Feb 25, 2023

Also i found the error, link dependencies are not being installed, there are multiple opened issues for this

pnpm/pnpm#4842

pnpm/pnpm#5523

@OrJDev
Copy link
Owner

OrJDev commented Feb 26, 2023

closing, check the issues above to see the progress, will update when it is fixed.

@OrJDev OrJDev closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants