Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some controls' rendering in Storybook #153

Open
julien-deramond opened this issue Feb 15, 2024 · 0 comments
Open

Fix some controls' rendering in Storybook #153

julien-deramond opened this issue Feb 15, 2024 · 0 comments
Labels
bug Something isn't working docs

Comments

@julien-deramond
Copy link
Member

Description

#151 was a complex PR that was getting rid of addon-knobs. In the process of doing that, something was not handled completely.

As you can see in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gauge--gauge&args=shapePercent:33, when you modify the value of shape.percent in the "Controls" tab, the value is taken into account in the view but the value doesn't change in the "Controls" view; it stays to 15/100.

In this same view, the boolean default value is not set in the "Controls" view. However, the color and number inputs work correctly.

In https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gaugewithinner--gauge-with-inner, the text input in the "Controls" view doesn't change even if the value is well-changed on the map rendering side.

Same thing in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/shapes--shapes where the default radio buttons values are not set.

There's an undefined issue globally in the way the "Controls" panel view is updated/synchronized.

@julien-deramond julien-deramond added bug Something isn't working docs labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs
Projects
None yet
Development

No branches or pull requests

1 participant