Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Headers > Breadcrumb #891

Open
Tracked by #537
julien-deramond opened this issue Nov 9, 2021 · 1 comment · May be fixed by #2003
Open
Tracked by #537

Local Headers > Breadcrumb #891

julien-deramond opened this issue Nov 9, 2021 · 1 comment · May be fixed by #2003

Comments

@julien-deramond
Copy link
Member

julien-deramond commented Nov 9, 2021

References

  • Orange Design System: Modules > Local Headers:
    • Breadcrumb On White - WEB-LOC-BCR-001
    • Breadcrumb On Black - WEB-LOC-BCR-001
    • Breadcrumb On Supporting Colour - WEB-LOC-BCR-003

More info

Two cents from @ffoodd:

Well, I guess it already kind of work: to fully support colored background, I think we'd need to add some color inheritance to breadcrumb items.

.breadcrumb-item a {
  color: inherit;
}

Also the separator should get that color too, so it'd need some mask-image love:

  1. set content to an empty string ("")
  2. apply the SVG in var() as a mask-image (and probably set mask-size and mask-position alongside)
  3. inherit color as background, thanks to background-color: currentColor;

Should do the trick! See Back-to-top link or social buttons for examples.

  • Tweak breadcrumbs to use mask and inherit color, so that .bg-* utilities work on them.
@louismaximepiton
Copy link
Member

Does it mean that we should set the content at "" every time ? then we couldn't have content: "/".

@louismaximepiton louismaximepiton linked a pull request Apr 20, 2023 that will close this issue
15 tasks
@louismaximepiton louismaximepiton self-assigned this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants