Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form controls padding inconsistencies? #2343

Open
julien-deramond opened this issue Oct 26, 2023 · 0 comments
Open

Form controls padding inconsistencies? #2343

julien-deramond opened this issue Oct 26, 2023 · 0 comments

Comments

@julien-deramond
Copy link
Member

Description

While working on #2341, we fixed the right padding of the valid feedback icon so that this space is exactly the same as the left, top and bottom padding:

Screenshot 2023-10-26 at 14 01 44

So it's working pretty well but there's a question in terms of design that needs to be double-checked with designers.
The left padding of an input (in red) becomes bigger than the green part. Do we want it like this or not?

It's not that inconsistent because, without the valid icon, it works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant