Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

"A review has been left on your transaction" email sent to reviewer #4359

Open
lucadgtrip opened this issue Feb 20, 2020 · 3 comments · May be fixed by #4426
Open

"A review has been left on your transaction" email sent to reviewer #4359

lucadgtrip opened this issue Feb 20, 2020 · 3 comments · May be fixed by #4426
Assignees
@fedealconada
Labels
good first issue Good for newcomers notifications P2 Small number of users are affected, major cosmetic issue

Comments

@lucadgtrip
Copy link

I left a review and then got this message

Screenshot 2020-02-20 at 16 23 50

which seems strange as it's telling me something I know.
@franckc franckc added bug Something isn't working as intended notifications P2 Small number of users are affected, major cosmetic issue good first issue Good for newcomers and removed bug Something isn't working as intended labels Feb 24, 2020
@franckc
Copy link
Collaborator

franckc commented Feb 24, 2020

The logic deciding what emails to send is here.

We should review it to make sure it makes sense.

@rembrandtreyes
Copy link
Member

@franckc Yeah looks like we have it reversed. We should flip this to the seller side. Or for two-way visibility, we change the language of this email to be something like, "Your review has been posted to the seller's listing."

I'll review the other email flows to make sure they all make sense.

@fedealconada
Copy link

I'll grab this one if possible @rembrandtreyes

@fedealconada fedealconada linked a pull request Apr 6, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fedealconada fedealconada

Labels
good first issue Good for newcomers notifications P2 Small number of users are affected, major cosmetic issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP][GH-4359] fix wrong email notification after leaving review fedealconada/origin
4 participants
@franckc @fedealconada @rembrandtreyes @lucadgtrip