Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix type #367 #368

Merged
merged 1 commit into from Mar 21, 2024
Merged

chore: fix type #367 #368

merged 1 commit into from Mar 21, 2024

Conversation

hellmor
Copy link
Collaborator

@hellmor hellmor commented Jan 31, 2024

Solve the issues mentioned in #367.

Solve the issues mentioned in Issue367.
@hellmor hellmor added the bug Something isn't working label Jan 31, 2024
@hellmor hellmor added this to the 0.7 milestone Jan 31, 2024
@hellmor hellmor linked an issue Jan 31, 2024 that may be closed by this pull request
@lslzl3000 lslzl3000 changed the title fix: Solve the issues mentioned in Issue 367 chore: fix type #367 Jan 31, 2024
@lslzl3000 lslzl3000 merged commit 7ab2f48 into Orillusion:dev Mar 21, 2024
1 check passed
hellmor added a commit to hellmor/orillusion that referenced this pull request May 22, 2024
commit 590b213
Author: ShuangLiu <liu.shuang@huasheng.io>
Date:   Wed May 22 20:47:28 2024 +0800

    feat(buffer): return promise result

commit 4e05c04
Author: ShuangLiu <liu.shuang@huasheng.io>
Date:   Wed May 1 03:04:32 2024 +0800

    fix(picker): missing normal in pickFire

commit 1ab8718
Author: hellmor <dymmky@126.com>
Date:   Thu Mar 21 20:36:23 2024 +0800

    fix: Error when lineJoin is set to round (Orillusion#366)

    * fix: Error when lineJoin is set to round

    Fix error when lineJoin is set to round.

    * fix: Remove eventListener.

    Remove the eventListener when transform is disposed.

commit 7ab2f48
Author: hellmor <dymmky@126.com>
Date:   Thu Mar 21 20:35:36 2024 +0800

    fix: Solve the issues mentioned in Issue367 (Orillusion#368)

    Solve the issues mentioned in Issue367.

commit 51ff3ee
Author: Codeboy <zhangcanbo@outlook.com>
Date:   Thu Mar 21 20:35:09 2024 +0800

    fix: object is disabled after removeChild  (Orillusion#381)

    * chore: remove sample_candleflame maskMap

    * fix: addChild and removeChild related

    * chore: remove log

commit 65bda50
Author: ShuangLiu <liu.shuang@huasheng.io>
Date:   Wed Mar 13 03:59:02 2024 +0800

    fix(loaderFunctions): onUrl on loadGltf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: 这里的代码似乎有问题
2 participants