Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS fixes to improve the debugger #124

Open
pbiggar opened this issue May 23, 2019 · 4 comments
Open

CSS fixes to improve the debugger #124

pbiggar opened this issue May 23, 2019 · 4 comments

Comments

@pbiggar
Copy link
Contributor

pbiggar commented May 23, 2019

To make the debugger useful in our app, we added this CSS. It doesn't make it completely usable, but it's an improvement.

#debug {
  min-height: 20px;
  z-index: 100;
  position: absolute;
  bottom: 0;
  right: 0;
  max-height: 500px;
  max-width: 500px;
  overflow: scroll;
}
#debug nav {
  max-width: 50%;
}
#debug nav .history span.details {
  width: 25px;
}
#debug nav .history span.message {
  width: calc(100% - 75px);
}
#debug nav .history span.index {
  width: 30px;
  clear: both;
}
@OvermindDL1
Copy link
Owner

Hmm, it was originally designed to be themed however the app wanted so it was left fairly basic, however setting up something a bit more useful would be nice! Do you want to do a PR? :-)

@OvermindDL1
Copy link
Owner

I'd think either just documenting it at the simpliest, or perhaps adding the above as a basic css mixin function that can be called so the user can add it to their own CSS handlers (and thus override it) would be best. Adding it directly to the debug view itself would make it pretty impossible to override then so not sure that should be done (and in fact any CSS on it should probably be pulled out, hmmm...).

@pbiggar
Copy link
Contributor Author

pbiggar commented May 26, 2019

For us, it wasn't a theming problem, it was that the debugger was unusable (important parts weren't clickable because the display was much to large, off screen, or covered/invisible. We had a direct port from Elm, and the Elm debugger didn't have any of these issues. Directionally, we may want to copy the Elm Debugger HTML/CSS to make this better.

@OvermindDL1
Copy link
Owner

Ah yeah that can indeed happen. ^.^;

Hmm, so a basic CSS mixin perhaps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants