Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null pointer exception in an edge case where the SMP returns 404 but with an empty xml response body #47

Open
orco opened this issue Oct 4, 2022 · 1 comment
Labels
Under review Issues currently being reviewed
Milestone

Comments

@orco
Copy link

orco commented Oct 4, 2022

We recently run into an issue where we do a lookup but the SMP(in this case smp.difi.no) returns an xml header with a commented out body together with HTTP status 404. Curl output follows below.
In network.oxalis.vefa.peppol.lookup.reader.MultiReader.parseServiceGroup it results in an NPE with the message:

Cannot invoke "network.oxalis.vefa.peppol.lookup.api.FetcherResponse.getNamespace()" because "response" is null

Not sure if this should be handled by vefa-peppol or in the code that uses vefa-peppol?

`curl -v B-8c30ca3b541456dde1172d2f56b737d3.iso6523-actorid-upis.edelivery.tech.ec.europa.eu/iso6523-actorid-upis::0192:981299108

  • About to connect() to B-8c30ca3b541456dde1172d2f56b737d3.iso6523-actorid-upis.edelivery.tech.ec.europa.eu port 80 (#0)
  • Trying 51.144.60.163...
  • Connected to B-8c30ca3b541456dde1172d2f56b737d3.iso6523-actorid-upis.edelivery.tech.ec.europa.eu (51.144.60.163) port 80 (#0)

GET /iso6523-actorid-upis::0192:981299108 HTTP/1.1
User-Agent: curl/7.29.0
Host: B-8c30ca3b541456dde1172d2f56b737d3.iso6523-actorid-upis.edelivery.tech.ec.europa.eu
Accept: /

< HTTP/1.1 404
< Date: Tue, 04 Oct 2022 13:38:55 GMT
< Content-Type: text/xml;charset=UTF-8
< Content-Length: 313
< Connection: keep-alive
< X-Content-Type-Options: nosniff
< X-XSS-Protection: 1; mode=block
< Cache-Control: no-cache, no-store, max-age=0, must-revalidate
< Pragma: no-cache
< Expires: 0
< X-Frame-Options: DENY
<

`
@aaron-kumar aaron-kumar added the Under review Issues currently being reviewed label Oct 21, 2022
@aaron-kumar aaron-kumar added this to the 5.x.x milestone Oct 25, 2022
@aaron-kumar aaron-kumar modified the milestones: 5.x.x, 6.x.x Jan 16, 2023
@eivinhb
Copy link

eivinhb commented Mar 29, 2023

Yes, we also see this in production.

@aaron-kumar aaron-kumar modified the milestones: 6.x.x, 7.x.x Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under review Issues currently being reviewed
Projects
Status: Future
Development

No branches or pull requests

3 participants