Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass value to custom delete function #19

Open
PFython opened this issue Jan 28, 2021 · 1 comment
Open

Pass value to custom delete function #19

PFython opened this issue Jan 28, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@PFython
Copy link
Owner

PFython commented Jan 28, 2021 •
edited

.delete() currently just takes a key/attribute name argument which means the actual value will be deleted before any custom delete function is called. It may be important to have that value available (e.g. backup?)

Alternatively ensure custom delete (and save) are called BEFORE delitem etc.
@PFython PFython added enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on labels Jan 30, 2021
@PFython
Copy link
Owner Author

PFython commented Jan 30, 2021

Labelled as "wontfix" after Version 1.8.0 simply because the main authors don't currently have the time for non essential enhancements. If there's a huge uptake in people using CleverDict and asking for this feature that may change, or if you're reading this why not Fork, develop a solution, and contribute a Pull Request yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PFython