Execution error on php v7.4 with excluded subcodebase containing php v8+

[94noni]

Support question

Execution of php-cs-fixer v3.14 with runtime php v7.4 on a codebase that may have some php v8+ code (attributes)

My codebase is like this:

// this is mainly a code monolith repository containing bundle/component/etc
  - src
    - Bundle
      - MyBundle (with php v8+ code)
      - MyOtherBundle (with php v7+ code)
    - core (with php v7+ code)

Even if I exclude() the folder path in my config file, the error outputs:

Files that were not fixed due to errors reported during linting before fixing:                                                                                             
   1) src/Bundle/MyBundle/Twig/CartRequestForm.php  

---

• is it even possible ?
• is there a failure in the config file with excluded folder ?

Many thanks,

[kubawerlos]

is there a failure in the config file with excluded folder ?

Definitely, can you share the config?

[94noni]

Will definitly do tomorrow for sure
Thx for stopping by :)

[94noni]

@kubawerlos here it is:

<?php

use PhpCsFixer\Config;
use PhpCsFixer\Finder;

$config = new Config();

return $config
    ->setRiskyAllowed(true)
    ->setRules([
        '@PSR1' => true,
        '@PSR2' => true,
        '@Symfony' => true,
        '@Symfony:risky' => true,
        '@DoctrineAnnotation' => true,
        ...
    ])
    ->setFinder(
        Finder::create()
            ->in([
                __DIR__ . '/src',
                __DIR__ . '/tests',
            ])
            ->exclude([
                'src/Company/Bundle/CartRequestBundle',
                // same with this:
                // `__DIR__ . '/src/Company/Bundle/CartRequestBundle',`
            ])
    )
;

[kubawerlos]

As I suspected, classic mistake with exclude:

// directories passed as argument must be relative to the ones defined with the in() method
$finder->in(DIR)->exclude('ruby');

(from https://symfony.com/doc/current/components/finder.html)

[Wirone]

In other words: try Company/Bundle/CartRequestBundle 😉.

[94noni]

I will try this and report back

I've read the doc but found it hard to understand thus my post
Opened a PR to try to improve this a bit, of course feel free to close if you found unrelated

anyway, thank you a lot for your time and answers