feat: Support more FQCNs cases in fully_qualified_strict_types
#7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
added
kind/feature
topic/fqcn
Wirone
changed the title
fully_qualified_strict_types
mvorisek
reviewed
Nov 23, 2023
mvorisek
reviewed
Nov 23, 2023
This is basically "cherry-pick" from PR 6395, that's why SpacePossum is assigned as an author of the changes.
It is failing on main branch too, so it should be done separately.
Wirone
force-pushed
the
codito/fqcn-more-cases
branch
from
af2fb3c
to
ffeb22a
Compare
kubawerlos
approved these changes
Dec 15, 2023
|
Thank you @SpacePossum for this great work 🍻! |
|
Thanks @Wirone for all your time put into this, nice to see these changes! : ) |
mvorisek
added a commit
to mvorisek/PHP-CS-Fixer
that referenced
this pull request
Dec 26, 2023
…es` (PHP-CS-Fixer#7459)" This reverts commit 1bc8e82.
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
…-CS-Fixer#7459) Co-authored-by: SpacePossum <possumfromspace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a ~cherry-pick of #6395 (all the credit goes to @SpacePossum), with slight changes:
shorten_globals_in_global_namespaceconfiguration option was dropped, because in the meantime we introducedleading_backslash_in_global_namespace, which is utilised hereFullyQualifiedStrictTypesFixerremoves leading backslash without properly imported symbol #7458 (this PR does not fix this, it has to be handled separately)Fixes #6077
Fixes #4309
ℹ️ PR was revived as-is, it requires review - I'm going to do it too, but any feedback is welcome 🙂.