DX: replace fixture classes with anonymous ones #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you gather all of those in one PR? |
kubawerlos
changed the title
keradus
reviewed
Dec 11, 2023
Comment on lines
+83
to
+85
| private function createStdinStreamDouble(): object | ||
| { | ||
| return new class() { |
There was a problem hiding this comment.
I know it was not there initially, but can we somehow add any typehint here other than object ?
There was a problem hiding this comment.
Unfortunately no, https://github.com/composer/composer/blob/2.6.6/src/Composer/Installer/BinaryInstaller.php#L248 does not have it either.
keradus
reviewed
Dec 11, 2023
keradus
approved these changes
Dec 11, 2023
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.