Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better OS detection in integration tests #7547

Merged
merged 1 commit into from Dec 11, 2023
Merged

fix: Better OS detection in integration tests #7547

merged 1 commit into from Dec 11, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 11, 2023 •
edited

skipped message before this fix:

Unsupported OS (WINNT) for "xxx.test", allowed are: Linux, Darwin, Windows.

@mvorisek mvorisek marked this pull request as ready for review December 11, 2023 02:01
@mvorisek mvorisek changed the title Fix integration tester PHP_OS_FAMILY detection fix: integration tester PHP_OS_FAMILY detection Dec 11, 2023
Wirone
Wirone approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvorisek nice catch 🙂.

@Wirone Wirone changed the title fix: integration tester PHP_OS_FAMILY detection fix: Better OS detection in integration tests Dec 11, 2023
@Wirone Wirone enabled auto-merge (squash) December 11, 2023 12:03
@Wirone Wirone merged commit 238c150 into PHP-CS-Fixer:master Dec 11, 2023
24 checks passed
@mvorisek mvorisek deleted the fix_win_detect branch December 11, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @Wirone