DX: add types to anonymous functions #7561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
approved these changes
Dec 15, 2023
keradus
reviewed
Dec 16, 2023
| @@ -308,7 +308,7 @@ private function isTypeSortable(TypeAnalysis $type): bool | |||
| */ | |||
| private function collectDisjunctiveNormalFormTypes(string $type): array | |||
| { | |||
| $types = array_map(static function ($subType) { | |||
There was a problem hiding this comment.
any SCA to prevent adding another not-typed lambdas?
There was a problem hiding this comment.
I've spotted these with slam/phpstan-extensions but was not able to fix all of the types (some lambdas need multiple types and with PHP 7.4 we cannot have them).
There was a problem hiding this comment.
@kubawerlos
maybe for those cases we can add mixed typehint, and prevent adding any more untyped lambdas?
then, we deal with mixed afterwars
There was a problem hiding this comment.
Definitely, as soon as we drop PHP 7.4 support.
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.