DX: do not allow overriding constructor of PHPUnit\Framework\TestCase

[kubawerlos]

In PHPUnit 9 it would work as all parameters are optional: https://github.com/sebastianbergmann/phpunit/blob/9.6.15/src/Framework/TestCase.php#L489

However, in PHPUnit is not the same: https://github.com/sebastianbergmann/phpunit/blob/10.5.3/src/Framework/TestCase.php#L322C46-L322C46

[coveralls]

coverage: 94.789%. remained the same
when pulling e1a4427 on 6b7562617765726c6f73:dx_testNotDefiningConstructor
into 4c57217 on PHP-CS-Fixer:master.

[keradus]

@kubawerlos
whenever doing things like this, use the message parameter. JohnDoe will see that they done sth we didn't want, but without understanding "why" we don't want it.

[Wirone]

I believe the default messages for each assert are good enough in most cases, it's not like the developer won't know anything about the failure.

[keradus]

huh? @Wirone , once more my msg:

JohnDoe will see that they done sth we didn't want, but without understanding "why" we don't want it.

So let say JohnDoe wanted to contribute for first time, they did new test and use constructor in it.
Then, they get this result:

ker@d ~/github/FriendsOfPHP/PHP-CS-Fixer λ ./vendor/bin/phpunit tests/SomeTest.php 
PHPUnit 9.6.15 by Sebastian Bergmann and contributors.

Testing PhpCsFixer\Tests\SomeTest
....F                                                                                                                                                           5 / 5 (100%)

Time: 00:00.045, Memory: 26.50 MB

There was 1 failure:

1) PhpCsFixer\Tests\SomeTest::testNotDefiningConstructor
Failed asserting that two strings are not identical.

/Users/d.ruminski/github/FriendsOfPHP/PHP-CS-Fixer/tests/TestCase.php:33

So, JohnDoe got the msg what is failing (testNotDefiningConstructor), yet without knowledge WHY not do define that constructor.