DX: fix checking test class extends PhpCsFixer\Tests\TestCase
#7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Dec 16, 2023
tests/AutoReview/ProjectCodeTest.php
Outdated
| @@ -309,6 +316,12 @@ public static function provideDataProviderMethodCases(): iterable | |||
| */ | |||
| public function testThatTestClassCoversAreCorrect(string $testClassName): void | |||
| { | |||
| if (DocumentationTest::class === $testClassName) { | |||
There was a problem hiding this comment.
Why this class cannot have cover annotation tested ?
There was a problem hiding this comment.
1) PhpCsFixer\Tests\AutoReview\ProjectCodeTest::testThatTestClassCoversAreCorrect with data set #7 ('PhpCsFixer\Tests\AutoReview\D...onTest')
Class "\PhpCsFixer\AutoReview\Documentation" does not exist
There was a problem hiding this comment.
Hint: this exception is not intuutive. When doing any exceptions for some of the tests , provide in-code comment with reason. Otherwise John doe will not be aware why it's needed (and fact that "if they remove hack tests will fail so they will not remove the hack" is not helping them to understand why we have it in first place)
There was a problem hiding this comment.
I thought whoever could be interested can go to DocumentationTest and see the @covers there.
However, let's get rid of the exception and update @covers for DocumentationTest.
keradus
reviewed
Dec 16, 2023
| @@ -848,7 +861,7 @@ private static function getTestClasses(): array | |||
|
|
|||
| $finder = Finder::create() | |||
| ->files() | |||
| ->name('*.php') | |||
| ->name('*Test.php') | |||
keradus
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.