test: check to have DataProviders code agnostic of PHP version

[keradus]

depends on PRs raised few mins ago

[coveralls]

coverage: 94.795%. remained the same
when pulling 3a65f9c on dx_cond
into 968e789 on master.

[kubawerlos]

Isn't it an overkill? I was thinking of simply checking for:

                    [T_STRING, 'PHP_VERSION_ID'],
                    [T_STRING, 'PHP_MAJOR_VERSION'],
                    [T_STRING, 'PHP_MINOR_VERSION'],
                    [T_STRING, 'PHP_RELEASE_VERSION'],
                    [T_STRING, 'phpversion'],

in any test file, as all those should be handled via @requires, right?

[kubawerlos]

Can we have it similar (#7580) to how we check preg_ functions calls?

[keradus]

We do not want preg_ at all (except of one file - Preg.php), because we have our Preg class.

For PHP_ in tests, I do not want to have it in data providers, but I'm OK to have it anywhere else. I think your approach is forbidding to use it anywhere else.
I would even consider to extend my approach to look not only within provide* class, but also within if conditions. Then, things like tests/FixerDefinition/VersionSpecificationTest.php won't need to be an exception

[kubawerlos]

Then, things like tests/FixerDefinition/VersionSpecificationTest.php won't need to be an exception

Aren't those 2 classes the only places we want to allow PHP version awareness? IMHO in all other places defined should be enough.

[keradus]

I do not understand the part of defined in context of discussion about where to use PHP_* constants.

I see no reason to prevent usage of PHP_* outside of data providers (or more explicitly - conditions inside them).

[kubawerlos]

I do not understand the part of defined in context of discussion about where to use PHP_* constants.

Any if (PHP_VERSION_*) could/should be replaced with if (defined('T_*').

I see no reason to prevent usage of PHP_* outside of data providers (or more explicitly - conditions inside them).

I look at it from the other side - I see no reason to allow using PHP_* in tests.

[keradus]

Then, let's extract all if(PHP_ and if(defined cleanups to #7581 , have it merged and see how many cases we have remaining, if any.