DX: remove symfony/phpunit-bridge
#7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Dec 21, 2023
|
|
||
| protected function tearDown(): void | ||
| { | ||
| if (null !== $this->previouslyDefinedErrorHandler) { |
There was a problem hiding this comment.
is anything around sebastianbergmann/phpunit#5532 helping us to avoid local implementation?
There was a problem hiding this comment.
I wasn't able to figure anything out that would still work with PHP 7.4 and PHPUnit 9.
keradus
reviewed
Dec 21, 2023
keradus
reviewed
Dec 21, 2023
keradus
reviewed
Dec 21, 2023
keradus
reviewed
Dec 21, 2023
Comment on lines
+38
to
+40
| foreach ($this->expectedDeprecations as $expectedDeprecation) { | ||
| self::assertContains($expectedDeprecation, $this->actualDeprecations); | ||
| } |
There was a problem hiding this comment.
what if count(actual) > count(expected) ?
we could miss some exceptions. I suggest to check them too
There was a problem hiding this comment.
I will do that in separate PR, it will look quite funny, I promise.
keradus
reviewed
Dec 21, 2023
|
|
||
| /** | ||
| * @TODO change access to protected and pass the parameter when PHPUnit 9 support is dropped | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| * @param string $message | |
| */ |
possible ?
There was a problem hiding this comment.
Ondrej says "no":
------ ----------------------------------------------------------
Line tests/TestCase.php
------ ----------------------------------------------------------
60 PHPDoc tag @param references unknown parameter: $message
------ ----------------------------------------------------------
There was a problem hiding this comment.
yeah, was afraid some sca will fail on "future param"
keradus
approved these changes
Dec 21, 2023
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both listeners and
expectDeprecationgot removed in PHPUnit 10, so to keep checking for deprecations we need to have our implementation.We can move to the event system that got introduced in PHPUnit 10 when we use PHPUnit 10+ (requires supporting PHP 8.1+ only).