Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify tests not agnostic of PHP version #7581

Merged
merged 18 commits into from Dec 17, 2023
Merged

chore: unify tests not agnostic of PHP version #7581

merged 18 commits into from Dec 17, 2023

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Dec 16, 2023 •
edited

No description provided.

@coveralls
Copy link

coveralls commented Dec 16, 2023 •
edited

Coverage Status

coverage: 94.801%. remained the same
when pulling d0ce2b9 on 6b7562617765726c6f73:dx_unify_test_non_agnostic_of_php_version
into 817c319 on PHP-CS-Fixer:master.

@keradus keradus changed the title DX: unify tests for fixers not agnostic of PHP version chore: unify tests for fixers not agnostic of PHP version Dec 16, 2023
@kubawerlos kubawerlos marked this pull request as ready for review December 16, 2023 19:48
@keradus keradus mentioned this pull request Dec 16, 2023
Closed
keradus
keradus reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(marker for myself)

keradus
keradus reviewed Dec 16, 2023
View reviewed changes
phpstan.dist.neon Outdated Show resolved Hide resolved
@keradus keradus mentioned this pull request Dec 16, 2023
Merged
kubawerlos and others added 2 commits December 16, 2023 22:29
@kubawerlos @keradus
Apply suggestions from code review
0d52c2d 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@kubawerlos
Fixes
b874ecd
keradus
keradus reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(marker for myself)

@kubawerlos kubawerlos changed the title chore: unify tests for fixers not agnostic of PHP version chore: unify tests not agnostic of PHP version Dec 16, 2023
keradus
keradus reviewed Dec 16, 2023
View reviewed changes
tests/Tokenizer/Transformer/TypeIntersectionTransformerTest.php
@@ -63,7 +63,7 @@ function foo(){}
',
];

if (\PHP_VERSION_ID >= 8_01_00) {
if (\defined('T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG')) { // @TODO: drop condition when PHP 8.1+ is required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, please replace to dataprovider for 8.1.
very same reasoning. I think I already shared that ;)
#7580 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I've already shared I can't. If you can, maybe can you demonstrate it?

@keradus keradus merged commit ff9b6f4 into PHP-CS-Fixer:master Dec 17, 2023
25 checks passed
@kubawerlos kubawerlos deleted the dx_unify_test_non_agnostic_of_php_version branch December 17, 2023 08:44
@kubawerlos kubawerlos mentioned this pull request Dec 18, 2023
Closed
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@kubawerlos @danog
chore: unify tests not agnostic of PHP version (PHP-CS-Fixer#7581)
0bacace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @coveralls @keradus