fix: NativeTypeDeclarationCasingFixe - handle static property without type #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
approved these changes
Dec 17, 2023
|
|
||
| public function __construct() | ||
| { | ||
| parent::__construct(); | ||
|
|
||
| $this->propertyTypeModifiers = [[T_PRIVATE], [T_PROTECTED], [T_PUBLIC], [T_VAR]]; | ||
| $this->beforePropertyTypeTokens = ['{', ';', [T_PRIVATE], [T_PROTECTED], [T_PUBLIC], [T_VAR]]; |
There was a problem hiding this comment.
Shouldn't we add support for PHP8 attributes too? I know this is a fix PR, but maybe you would like to add it too 😉.
There was a problem hiding this comment.
Nevermind, auto-merge enabled 😆.
There was a problem hiding this comment.
Is it possible to add an attribute without visibility?
There was a problem hiding this comment.
There was a problem hiding this comment.
Will be working well, I guess we cannot make any failing test, and only add some to prevent regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7586