DX: Allow running smoke tests within Docker runtime #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Dec 21, 2023
| @@ -26,6 +26,7 @@ RUN if [ ! -z "$DOCKER_GROUP_ID" ] && [ ! getent group "${DOCKER_GROUP_ID}" > /d | |||
| && if [ ! -z "$DOCKER_USER_ID" ] && [ ! -z "$DOCKER_GROUP_ID" ] && [ ! getent passwd "${DOCKER_USER_ID}" > /dev/null ]; \ | |||
| then adduser -S -u "${DOCKER_USER_ID}" -G "$(getent group "${DOCKER_GROUP_ID}" | awk -F: '{printf $1}')" dev; \ | |||
| fi \ | |||
| && apk add git \ | |||
There was a problem hiding this comment.
we have it in line 6. is it not enough ? :(
There was a problem hiding this comment.
No, it's a different build target (sphinx-lint) 🙂.
keradus
approved these changes
Dec 21, 2023
Debugging tests with XDebug require Docker runtime (through `xdebug` utility), Smoke tests require Git, so Docker runtime requires Git 🤷.
Wirone
force-pushed
the
git-for-smoke-tests-within-docker
branch
from
ca55df8
to
4365b81
Compare
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging tests with XDebug require Docker runtime (through
xdebugutility), Smoke tests require Git, so Docker runtime requires Git 🤷.