feat: Enable symbol importing in @PhpCsFixer ruleset
#7629
Conversation
|
@nicolas-grekas are you interested in importing FQCNs in |
|
Naively I'd say yes but on second thought we have symbols that are not imported on purpose and we should have very few occurrences that need an actual fix. |
|
Rule is already available, you just need to run Fixer with |
Wirone
force-pushed
the
codito/enable-fqcn-importing-in-internal-ruleset
branch
from
c5dc561
to
929c850
Compare
| 'fully_qualified_strict_types' => [ | ||
| 'import_symbols' => true, | ||
| ], |
There was a problem hiding this comment.
FYI, changing rule configuration is not DX, it's feat - it affects users of project who decided to follow our public ruleset.
changing .php-cs-fixer.dist.php config is DX/chore
keradus
changed the title
@PhpCsFixer ruleset@PhpCsFixer ruleset
| @@ -86,7 +87,7 @@ public function listErrors(string $process, array $errors): void | |||
| $this->output->writeln(''); | |||
| $stackTrace = $e->getTrace(); | |||
| foreach ($stackTrace as $trace) { | |||
| if (isset($trace['class']) && \Symfony\Component\Console\Command\Command::class === $trace['class'] && 'run' === $trace['function']) { | |||
| if (isset($trace['class']) && Command::class === $trace['class'] && 'run' === $trace['function']) { | |||
There was a problem hiding this comment.
can you describe why we needed to add isset?
it was some warning in phpstan, or we changed the logic somewhere?
There was a problem hiding this comment.
isset() was already there, the only changes in this PR are: ruleset reconfiguration (manual) and applying CS fixes (automated). Here FQCN was shortened, nothing more.
There was a problem hiding this comment.
🤦🏻 with split-view, I misseen the check as it was visually broken to line above 🤦🏻
| @@ -30,6 +30,72 @@ | |||
| use PhpCsFixer\PhpunitConstraintIsIdenticalString\Constraint\IsIdenticalString; | |||
| use PhpCsFixer\Preg; | |||
| use PhpCsFixer\StdinFileInfo; | |||
| use PhpCsFixer\Tests\Fixer\ClassNotation\ClassAttributesSeparationFixerTest; | |||
Wirone
force-pushed
the
codito/enable-fqcn-importing-in-internal-ruleset
branch
from
929c850
to
a67266d
Compare
In general I believe it should be enabled for our codebase, the only place where it produces large overhead is
tests/Test/AbstractFixerTestCase.phpbut this list of tests should shrink in time so amount of imports will be reduced too.