- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: few SCA fixes and dev-tools update #7969
Conversation
} | ||
|
||
public static function tearDownAfterClass(): void | ||
{ | ||
parent::tearDownAfterClass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parent method is empty, this is superfluous. Same for setUpBeforeClass
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have no clue to call the parent method in child class if i only modify parent method. or if parent method is modified of PHPUnit level.
with that, whenever we override PHPUnit's method, i want to build on top, not to replace PHPUnit method
This reverts commit 5ce383a.
No description provided.