Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: few SCA fixes and dev-tools update #7969

Merged
merged 12 commits into from
Apr 29, 2024

Conversation

keradus
Copy link
Member

@keradus keradus commented Apr 25, 2024

No description provided.

keradus added 5 commits April 25, 2024 10:32

Verified

This commit was signed with the committer’s verified signature.
alexanderniebuhr Alexander Niebuhr

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@keradus keradus enabled auto-merge (squash) April 25, 2024 16:15
@coveralls
Copy link

coveralls commented Apr 25, 2024

Coverage Status

coverage: 96.115%. remained the same
when pulling e3b462e on keradus:dx_update
into e88707e on PHP-CS-Fixer:master.

}

public static function tearDownAfterClass(): void
{
parent::tearDownAfterClass();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parent method is empty, this is superfluous. Same for setUpBeforeClass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have no clue to call the parent method in child class if i only modify parent method. or if parent method is modified of PHPUnit level.

with that, whenever we override PHPUnit's method, i want to build on top, not to replace PHPUnit method

keradus added 2 commits April 29, 2024 13:17
This reverts commit 5ce383a.
@keradus keradus requested a review from Wirone April 29, 2024 21:14

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@keradus keradus merged commit deb34af into PHP-CS-Fixer:master Apr 29, 2024
26 checks passed
@keradus keradus deleted the dx_update branch May 1, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants